> On Nov. 13, 2015, 4:49 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 78
> > <https://reviews.apache.org/r/40285/diff/1/?file=1124942#file1124942line78>
> >
> >     This would then print the whole untar structure on every layer and 
> > every local image.
> >     
> >     What we should instead is that when untar fails we should print the 
> > stderr message from the pipe instead.
> 
> Jojy Varghese wrote:
>     I dont think it will print the entire file list since -v flag is not 
> provided to the tar. Since we are piping stderr to the mesos-slave's stderr, 
> the idea was that we will get the error logs at slave's stderr.

But the user then have to search the log around to see what's the tar's stderr? 
there isn't any message around this too so it's going to be scattered and 
probably be seperated as well.

If tar gave you "Not enough permissions" on stderr, how does a user know where 
to find that and also correlate that this message is from untar?

I think the better way is to read the stderr into here and return a Failure 
that can be correlated with the untar Future, and the caller can do:

"Failed to untar image xxxxxxxxx: Not enough permissions"

Let me know if you think otherwise.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106435
-----------------------------------------------------------


On Nov. 13, 2015, 8:13 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 8:13 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By piping stdout and stderr to logs, it would be easier to  debug problems 
> with untar.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> -------
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to