-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106775
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 97)
<https://reviews.apache.org/r/40285/#comment165547>

    As discussed, let's not created shared_ptr and update it in a .then block.
    
    Let's return a .then with a Future parameter and check in the .then block 
what the result is.


- Timothy Chen


On Nov. 16, 2015, 8:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 8:49 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By piping stdout and stderr to logs, it would be easier to  debug problems 
> with untar.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> -------
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to