> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1982
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1982>
> >
> >     EXPECT_TRUE((r3 - r3).empty());

This is added the previous code, so i'd like to drop this issue.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1986
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1986>
> >
> >     Add EXPECT_TRUE((r5 - r5).empty());

ditto


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, lines 1941-1948
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1941>
> >
> >     new line to split.
> >     
> >     It is suggested to add new line if one sentense is split to two lines.

I keep the same style with other code in `resources_test.cpp`, so i'd like to 
keep it as is.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 649
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138254#file1138254line649>
> >
> >     Did you get out how to leverage this default value in the code? ;-)

Did not try it, but I think calling `mutable_type()` (or similar) will set the 
type. `mutable_revocable()` will only create revocable object instead of 
RevocableInfo::type.


> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 800
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line800>
> >
> >     Do we need to update this? The standard revocable resource should be 
> > usage slack

I mean unset RevocableInfo::type; maybe `Unset RevocableInfo::type revocable 
resource` is better.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107732
-----------------------------------------------------------


On Nov. 24, 2015, 3:24 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0b8289f 
>   include/mesos/v1/mesos.proto c98f2a4 
>   src/common/resources.cpp b4abf54 
>   src/tests/resources_tests.cpp dbd39cd 
>   src/v1/resources.cpp 8488c31 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to