-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107493
-----------------------------------------------------------



include/mesos/mesos.proto (line 643)
<https://reviews.apache.org/r/40375/#comment166725>

    s/oversubscription/oversubscription for allocations



include/mesos/mesos.proto (line 647)
<https://reviews.apache.org/r/40375/#comment166609>

    The project name may need update to ""oversubscription for reservations"



src/tests/resources_tests.cpp (line 802)
<https://reviews.apache.org/r/40375/#comment166621>

    s/Standard/USAGE_SLACK



src/tests/resources_tests.cpp (lines 804 - 805)
<https://reviews.apache.org/r/40375/#comment166732>

    one line



src/tests/resources_tests.cpp (lines 812 - 813)
<https://reviews.apache.org/r/40375/#comment166733>

    one line



src/tests/resources_tests.cpp (line 1899)
<https://reviews.apache.org/r/40375/#comment166728>

    new line



src/tests/resources_tests.cpp (line 1929)
<https://reviews.apache.org/r/40375/#comment166729>

    new line



src/tests/resources_tests.cpp (line 1931)
<https://reviews.apache.org/r/40375/#comment166730>

    new line



src/tests/resources_tests.cpp (line 1933)
<https://reviews.apache.org/r/40375/#comment166731>

    new line



src/tests/resources_tests.cpp (line 1937)
<https://reviews.apache.org/r/40375/#comment166727>

    I think we can still use "sum" here



src/tests/resources_tests.cpp (line 1961)
<https://reviews.apache.org/r/40375/#comment166726>

    s/revocable/USAGE_SLACK revocable


- Guangya Liu


On 十一月 21, 2015, 3:47 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated 十一月 21, 2015, 3:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd 
>   include/mesos/v1/mesos.proto e71ddda 
>   src/common/resources.cpp f1da323 
>   src/tests/resources_tests.cpp 0d084fd 
>   src/v1/resources.cpp 6f50101 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to