----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107732 -----------------------------------------------------------
include/mesos/mesos.proto (line 649) <https://reviews.apache.org/r/40375/#comment167021> Did you get out how to leverage this default value in the code? ;-) src/common/resources.cpp (lines 92 - 93) <https://reviews.apache.org/r/40375/#comment167020> // To keep backward compatibility, resources without revocable type are considered same as resources with USAGE_SLACK type. src/common/resources.cpp (lines 94 - 95) <https://reviews.apache.org/r/40375/#comment167006> bool operator==( const Resource::RevocableInfo& left, const Resource::RevocableInfo& right) src/common/resources.cpp (lines 115 - 116) <https://reviews.apache.org/r/40375/#comment167007> bool operator!=( const Resource::RevocableInfo& left, const Resource::RevocableInfo& right) src/tests/resources_tests.cpp (line 800) <https://reviews.apache.org/r/40375/#comment167009> Do we need to update this? The standard revocable resource should be usage slack src/tests/resources_tests.cpp (lines 1908 - 1909) <https://reviews.apache.org/r/40375/#comment167013> new line src/tests/resources_tests.cpp (lines 1912 - 1913) <https://reviews.apache.org/r/40375/#comment167014> new line src/tests/resources_tests.cpp (lines 1941 - 1948) <https://reviews.apache.org/r/40375/#comment167015> new line to split. It is suggested to add new line if one sentense is split to two lines. src/tests/resources_tests.cpp (line 1982) <https://reviews.apache.org/r/40375/#comment167016> EXPECT_TRUE((r3 - r3).empty()); src/tests/resources_tests.cpp (line 1986) <https://reviews.apache.org/r/40375/#comment167017> Add EXPECT_TRUE((r5 - r5).empty()); src/v1/resources.cpp (lines 93 - 105) <https://reviews.apache.org/r/40375/#comment167019> update this to handle backward compatibility issue src/v1/resources.cpp (lines 1365 - 1368) <https://reviews.apache.org/r/40375/#comment167018> Losing no type case - Guangya Liu On 十一月 24, 2015, 7:24 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40375/ > ----------------------------------------------------------- > > (Updated 十一月 24, 2015, 7:24 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-3888 > https://issues.apache.org/jira/browse/MESOS-3888 > > > Repository: mesos > > > Description > ------- > > MESOS-3888: We need to distinguish revocable resource for usage slack and > allocation slack. > > > Diffs > ----- > > include/mesos/mesos.proto 0b8289f > include/mesos/v1/mesos.proto c98f2a4 > src/common/resources.cpp b4abf54 > src/tests/resources_tests.cpp dbd39cd > src/v1/resources.cpp 8488c31 > > Diff: https://reviews.apache.org/r/40375/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
