> On 十二月 3, 2015, 9:19 p.m., Joseph Wu wrote: > > It would be a good idea to start writing tests for each of these changes. > > You should probably do so in a new `master_<feature>_test.cpp` file. > > > > We have tests for master flags like this: > > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1092-L1108
Joseph, shall we add those test cases when implemented some basic features? I saw that most test cases are related to some function. Thanks! - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108885 ----------------------------------------------------------- On 十二月 3, 2015, 4:35 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40339/ > ----------------------------------------------------------- > > (Updated 十二月 3, 2015, 4:35 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-3887 > https://issues.apache.org/jira/browse/MESOS-3887 > > > Repository: mesos > > > Description > ------- > > Added a flag to master to enable optimistic offers. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 1cd8d16661568010901e74705375e7719cdfb8a0 > src/master/allocator/mesos/hierarchical.cpp > a8f65b72488505afd3677ecdeb9b821ea27af7e0 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 > src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > a45b3dd0a8237fdd080536cb9ab600e71ad939d3 > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_quota_tests.cpp c9d78cffc30539ce2d29360b231fcaf9e5b592ea > src/tests/persistent_volume_endpoints_tests.cpp > ac46806a712113170b349a969a9f1132723116f0 > src/tests/reservation_endpoints_tests.cpp > 142b7c61e08804417df639551926bf7fe3da9680 > src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 > src/tests/resource_offers_tests.cpp > 0bad45dd1dabecc88fef1ab46e8ea26718070b33 > src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 > > Diff: https://reviews.apache.org/r/40339/diff/ > > > Testing > ------- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
