> On Dec. 3, 2015, 1:19 p.m., Joseph Wu wrote: > > It would be a good idea to start writing tests for each of these changes. > > You should probably do so in a new `master_<feature>_test.cpp` file. > > > > We have tests for master flags like this: > > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1092-L1108 > > Guangya Liu wrote: > Joseph, shall we add those test cases when implemented some basic > features? I saw that most test cases are related to some function. Thanks!
I'd recommend starting a test file (in a separate review) anyway. It's perfectly fine to write part of a test, then augment the test later in the review chain, as you implement more of the feature. For example: https://reviews.apache.org/r/37172/diff/8#3 https://reviews.apache.org/r/37283/diff/6#0 - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108885 ----------------------------------------------------------- On Dec. 9, 2015, 5:05 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40339/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 5:05 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-3887 > https://issues.apache.org/jira/browse/MESOS-3887 > > > Repository: mesos > > > Description > ------- > > Added a flag to master to enable optimistic offers. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 > src/master/master.cpp 7acdc0a5d23a606eac2f37f4b7dd021c5a4fceb7 > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_quota_tests.cpp 12820fcf7c0d2a791071464ad8ed738664ad85de > src/tests/persistent_volume_endpoints_tests.cpp > 0a03b5f1ac7dec14bd99c31768f86100f2b60616 > src/tests/reservation_endpoints_tests.cpp > c3833d0949df42c9f8dadf3c6e6b0b49e6cbdce9 > src/tests/reservation_tests.cpp 3405b47c367e3c20e2a9139ab95dd8fd1805ea8d > src/tests/resource_offers_tests.cpp > 0bad45dd1dabecc88fef1ab46e8ea26718070b33 > src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 > > Diff: https://reviews.apache.org/r/40339/diff/ > > > Testing > ------- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
