----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review109683 -----------------------------------------------------------
Can we also update the V1 protobufs since this would be external user-facing ? include/mesos/mesos.proto (line 1568) <https://reviews.apache.org/r/41187/#comment169288> Why `Parameters` and not just `Labels` ? Also why not name the field as `labels` as is being done in other places in the file ? - Anand Mazumdar On Dec. 10, 2015, 3:32 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41187/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 3:32 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Adding labels field to Port information, for service discovery to associate > arbitrary tags by applications to ports for a given task. > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > > Diff: https://reviews.apache.org/r/41187/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
