> On Dec. 15, 2015, 11:32 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, lines 1561-1567 > > <https://reviews.apache.org/r/41187/diff/5/?file=1165160#file1165160line1561> > > > > Can you please split the comments to different fields just like others. > > > > // Represents the port on which the framework exposes its service on. > > required uint32 number = 1; > > > > ....
I was trying to follow the convention set by DiscoveryInfo. Speaking to Adam, looks like that's not a good example to follow. Going to move the comments per field. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110576 ----------------------------------------------------------- On Dec. 15, 2015, 10:11 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41187/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 10:11 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Adding labels field to Port information, for service discovery to associate > arbitrary tags by applications to ports for a given task. > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41187/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
