-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41187/#review110472
-----------------------------------------------------------

Ship it!


Looks good, but needs a little documentation.


include/mesos/v1/mesos.proto (lines 1560 - 1567)
<https://reviews.apache.org/r/41187/#comment170403>

    I agree with Guangya. Could you improve the comment for this protobuf 
message, explaining what protocol and visibility should mean here too?


- Adam B


On Dec. 14, 2015, 3:34 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41187/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 3:34 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3962
>     https://issues.apache.org/jira/browse/MESOS-3962
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding labels field to Port information, for service discovery to associate 
> arbitrary tags by applications to ports for a given task.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 
>   include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 
> 
> Diff: https://reviews.apache.org/r/41187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to