> On Dec. 15, 2015, 1:01 a.m., Guangya Liu wrote:
> > include/mesos/v1/mesos.proto, line 1567
> > <https://reviews.apache.org/r/41187/diff/3/?file=1163915#file1163915line1567>
> >
> >     It is always recommeded to add some comments here.

The whole Port message was missing comments so I augmented it by adding 
comments similar to DiscoveryInfo.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41187/#review110358
-----------------------------------------------------------


On Dec. 14, 2015, 11:34 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41187/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 11:34 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3962
>     https://issues.apache.org/jira/browse/MESOS-3962
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding labels field to Port information, for service discovery to associate 
> arbitrary tags by applications to ports for a given task.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 
>   include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 
> 
> Diff: https://reviews.apache.org/r/41187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to