> On Dec. 14, 2015, 10:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > <https://reviews.apache.org/r/40632/diff/6/?file=1161883#file1161883line431> > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a litte different with oversubscription: here, one > > reserved resources are counting twice in total. > > Guangya Liu wrote: > The allocation slack was decreased in 1304-1329 > > Jian Qiu wrote: > Just wondering the reason to set resources in allocaction slack when > add/update slave. It seems to me that you just need to calculate available > resources in allocate() and add allocation slack to the available there? > > Guangya Liu wrote: > If added slave with optimistic offer phase 1 enabled, then I want to make > sure that the log message in allocator is able to reflect that there are > allocation slack resources. SO just initializt allocation slack resources in > add/update slave and use it in allocate().
The result should be fine for this task; as we sync up online this morning, I'm confused by `slaves[slaveId].total` that included optimistic offer resources. I'd suggest to enhance our HLD on the counter in allocator; we also need to cover the code style in future :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review110154 ----------------------------------------------------------- On Dec. 14, 2015, 2:41 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 2:41 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
