> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 21-23 > > <https://reviews.apache.org/r/39456/diff/4/?file=1163799#file1163799line21> > > > > Just a kind reminder, https://issues.apache.org/jira/browse/MESOS-1718 > > is planning to move get exeucutor info from slave to master, after this is > > fixed, it will be master who will generate an executor. > > Jojy Varghese wrote: > Thanks again for the reminder. Do you think we should have this in the > documentation now or update the documentation when the change goes in?
I think that adding a TODO here by refering to MESOS-1718 is good enough. > On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 15-23 > > <https://reviews.apache.org/r/39456/diff/4/?file=1163799#file1163799line15> > > > > What about moveing this after ### Type of containerizers > > Jojy Varghese wrote: > Since this section is common to all containerizers, I liked it here. WDYT? > > Thanks Guangya. It is ok to put it here, my thinking is that it would be better if we put this after giving end user a concept introduciton for all of the containerizers. I do not have strong opinion on this and this depends on you ;-) - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110340 ----------------------------------------------------------- On Dec. 14, 2015, 8:37 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39456/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 8:37 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Documentation: added containerizer internals > > > Diffs > ----- > > docs/containerizer-internals.md PRE-CREATION > docs/home.md a01612ec8347eb8a7a9277b829365b6c3a1fe9e3 > > Diff: https://reviews.apache.org/r/39456/diff/ > > > Testing > ------- > > > Thanks, > > Jojy Varghese > >
