----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110681 -----------------------------------------------------------
Overall nit: add backticks around code/syscalls :) docs/containerizer-internals.md (line 9) <https://reviews.apache.org/r/39456/#comment170718> Note: Containerizers handle executors primarily. The only tasks the containerizers have control over are command tasks (launched by the executors included with Mesos). docs/containerizer-internals.md (line 10) <https://reviews.apache.org/r/39456/#comment170719> Nit: Oxford comma. docs/containerizer-internals.md (lines 18 - 19) <https://reviews.apache.org/r/39456/#comment170720> s/"containerizers"/`--containerizers`/ Ditto for all flags in the file. docs/containerizer-internals.md (lines 21 - 23) <https://reviews.apache.org/r/39456/#comment170721> Nit: reword "will generate an executor" to "will use a default executor". Nit: Can you surround `TaskInfo`, `mesos-executor`, and `mesos-docker-executor` with backticks? docs/containerizer-internals.md (line 24) <https://reviews.apache.org/r/39456/#comment170722> What are the potential changes MESOS-1718 could have? docs/containerizer-internals.md (line 75) <https://reviews.apache.org/r/39456/#comment170725> Doesn't it also fetch all the URIs? docs/containerizer-internals.md (lines 94 - 97) <https://reviews.apache.org/r/39456/#comment170728> Nit: periods at the ends. docs/containerizer-internals.md (line 105) <https://reviews.apache.org/r/39456/#comment170729> Nit: Oxford comma - Joseph Wu On Dec. 15, 2015, 10:22 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39456/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 10:22 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Documentation: added containerizer internals > > > Diffs > ----- > > docs/containerizer-internals.md PRE-CREATION > docs/home.md a01612ec8347eb8a7a9277b829365b6c3a1fe9e3 > > Diff: https://reviews.apache.org/r/39456/diff/ > > > Testing > ------- > > > Thanks, > > Jojy Varghese > >
