-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/#review110936
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41243, 41244]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 17, 2015, 3:44 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41244/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 3:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-4125
>     https://issues.apache.org/jira/browse/MESOS-4125
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The post-reviews.py script has similar problems to the bootstrap script
> in assuming that .git is a folder in the top-level directory of the git
> repo.  This may not be true when mesos is included as a submodule in
> another project. Use 'git rev-parse --git-dir' instead.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/41244/diff/
> 
> 
> Testing
> -------
> 
> I have been posting all of my reviews with this script since first creating 
> this commit. Tested both in an environment with and without mesos embedded as 
> a submodule inside another git repository.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to