> On Nov. 9, 2015, 2:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/http.cpp, line 1380 > > <https://reviews.apache.org/r/39466/diff/1/?file=1101382#file1101382line1380> > > > > Would it make sense to factor out the common functionality here and in > > the other `put` method? It looks like they are mostly concerned with > > creating the `Request`. > > Joerg Schad wrote: > I beleive a larger refactoring to just one common `Request` object would > also adress this issue. See https://issues.apache.org/jira/browse/MESOS-3256
Dropped as discussed. > On Nov. 9, 2015, 2:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 665 > > <https://reviews.apache.org/r/39466/diff/1/?file=1101383#file1101383line665> > > > > Breaking this in two test cases would reduce the need for `Now we do > > X`-style comments. It would also eliminate the reuse of `future`. > > Alexander Rukletsov wrote: > I think it's fine to have multiple related "test blocks" in a test case, > if it is clear where the problem is when a test fails. Reasons for that are > code reusal (less copy-paste code — less typos, less confusion, easier > reviewing, smaller codebase), faster compilation and saving `SetUp()`, > `TearDown()` cycles. > > In this case I think it's fine to have a single test. Dropped as discussed. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39466/#review105681 ----------------------------------------------------------- On Jan. 2, 2016, 1:47 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39466/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2016, 1:47 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3763 > https://issues.apache.org/jira/browse/MESOS-3763 > > > Repository: mesos > > > Description > ------- > > Added http::put request method. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > 3rdparty/libprocess/src/tests/http_tests.cpp > 19261502be220aaa40add7ce30a9b2b65d1d9fdc > > Diff: https://reviews.apache.org/r/39466/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
