----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113062 -----------------------------------------------------------
Bad patch! Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043] Failed command: ./support/apply-review.sh -n -r 39043 Error: 2016-01-06 13:09:59 URL:https://reviews.apache.org/r/39043/diff/raw/ [24594/24594] -> "39043.patch" [1] error: patch failed: src/master/master.hpp:951 error: src/master/master.hpp: patch does not apply - Mesos ReviewBot On Jan. 6, 2016, 8:03 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 8:03 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan > Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-3756 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP > Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP > authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials > are checked before the body of the request. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > PRE-CREATION > src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION > src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 > src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d > src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 > src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 > src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
