> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/constants.hpp, line 137
> > <https://reviews.apache.org/r/39043/diff/25/?file=1184412#file1184412line137>
> >
> >     s/mesos/Mesos

The string there is the actual value of the string, which is "mesos". That is 
the pattern in this file. I'll drop it now, but if you feel like it should be 
otherwise, please reopen.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/http.cpp, line 606
> > <https://reviews.apache.org/r/39043/diff/25/?file=1184416#file1184416line606>
> >
> >     You're changing this to `Forbidden()` here and in 
> > `Master::Http::destroyVolumes`, which has to do with RFC-2616. If this is 
> > the right way to respond to a failed authorization, you should also 
> > implement it that way for the other code paths that deal with 
> > authorization. It might be better to leave it be for now and create a 
> > separate JIRA for that?

I updated them all right now. Let's see what the author thinks.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/quota_handler.cpp, line 50
> > <https://reviews.apache.org/r/39043/diff/25/?file=1184419#file1184419line50>
> >
> >     `Forbidden` isn't used in this file.

It is now.


> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote:
> > src/master/quota_handler.cpp, line 349
> > <https://reviews.apache.org/r/39043/diff/25/?file=1184419#file1184419line349>
> >
> >     See my comment re `Unauthorized` & `Forbidden` above. This would have 
> > to be changed to `Forbidden` to be consistent with the change in 
> > `Master::Http::createVolumes`.

I changed to `Forbidden`. Though if the authors insist, I will change it back. 
It is my opinion that only the authorizer should return `Unauthorized`.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113065
-----------------------------------------------------------


On Jan. 6, 2016, 3:44 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 3:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
>   src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> f0cce190abc90f0fae84d6c3db20e8215c2d8132 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to