> On Jan. 6, 2016, 6:45 a.m., Jan Schlicht wrote: > > src/master/constants.hpp, line 137 > > <https://reviews.apache.org/r/39043/diff/25/?file=1184412#file1184412line137> > > > > s/mesos/Mesos > > Alexander Rojas wrote: > The string there is the actual value of the string, which is "mesos". > That is the pattern in this file. I'll drop it now, but if you feel like it > should be otherwise, please reopen.
Aha. Then I'd suggest writing either of these: - "mesos" - Mesos - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113065 ----------------------------------------------------------- On Jan. 6, 2016, 7:27 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 7:27 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan > Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-3756 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP > Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP > authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials > are checked before the body of the request. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > PRE-CREATION > src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION > src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 > src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d > src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 > src/master/master.hpp 2936d32c5e7b5b944bf16a1f261c7c54179900ec > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/master/quota_handler.cpp ac4da74686f524a66745b4a4e038c3d703ea1ee9 > src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c > src/tests/mesos.cpp 082e57bc73fad02de77e16e4b34451e6c0903038 > src/tests/persistent_volume_endpoints_tests.cpp > f0cce190abc90f0fae84d6c3db20e8215c2d8132 > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
