> On Jan. 7, 2016, 4:28 p.m., Alexander Rukletsov wrote:
> > src/tests/mesos.cpp, lines 435-438
> > <https://reviews.apache.org/r/39043/diff/29/?file=1186135#file1186135line435>
> >
> >     Since `setAuthenticator` is called in `Master::initialize()` won't it 
> > be a problem if we have multiple masters in a test case? Is 
> > `unsetAuthenticator()` idempotent? In tests multiple masters (and agents) 
> > share the same libprocess context (which is not true in production 
> > scenarios), I wonder whether this can be a problem.

That is exactly the reason it is a TODO, the global state of libprocess is 
rather inconvenient in this case.


> On Jan. 7, 2016, 4:28 p.m., Alexander Rukletsov wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, lines 900-902
> > <https://reviews.apache.org/r/39043/diff/29/?file=1186136#file1186136line900>
> >
> >     I suggest to make this change in a separate patch, but this fits one 
> > line now.

Done, moved to r/42027/


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113242
-----------------------------------------------------------


On Jan. 7, 2016, 5:02 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan 
> Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp 
> PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp f764915ff8bbf74b99a617e3c4735d38fc13e5f0 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp 93960f3728f9e68c085e6009fe975542d29d2551 
>   src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d 
>   src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to