> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > include/mesos/quota/quota.proto, line 54
> > <https://reviews.apache.org/r/42476/diff/2/?file=1200759#file1200759line54>
> >
> >     Given the naming scheme QuotaStatus wouldn't a more consistent name be 
> > QuotaSet?
> 
> Alexander Rukletsov wrote:
>     The question here is whether we will be reusing the same protobuf for, 
> say, update requests? My feeling is that this should be possible, hence a 
> more general naming.

It is ok with me, but it would be different for the Status and Remove Request 
(which are also subtypes of Requests).


> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 280
> > <https://reviews.apache.org/r/42476/diff/2/?file=1200760#file1200760line280>
> >
> >     Not an issue, but question/remark: the protoRequest.error() is most 
> > likely to be less concise compared to the previous error messages?
> 
> Alexander Rukletsov wrote:
>     Do you think we should hide the real error from an operator? I'd rather 
> have the precise error which an operator can show me on irc or user list : ).

I said not an issue :-), I just wanted to note that before we added more 
semantic meaning to the error string (as we checked for the error ourself) and 
the protobuf error will be most likely less precise.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review115127
-----------------------------------------------------------


On Jan. 18, 2016, 11:37 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4410
>     https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota_handler.cpp f44736cd5849d4fb22a75c1238d433a1c0c9708d 
>   src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to