> On Jan. 20, 2016, 9:14 a.m., Bernd Mathiske wrote:
> > docs/quota.md, line 94
> > <https://reviews.apache.org/r/42476/diff/3/?file=1201682#file1201682line94>
> >
> >     plural

I think we use single everywhere. It means total quota guarantee and shouldn't 
necessarily resemble the fact that there are multiple resources objects backing 
it. Moreover, it will require us to update `QuotaInfo` and `QuotaRequest` 
protos as well.


> On Jan. 20, 2016, 9:14 a.m., Bernd Mathiske wrote:
> > include/mesos/quota/quota.proto, line 62
> > <https://reviews.apache.org/r/42476/diff/3/?file=1201683#file1201683line62>
> >
> >     plural

See above.


> On Jan. 20, 2016, 9:14 a.m., Bernd Mathiske wrote:
> > src/master/quota_handler.cpp, line 327
> > <https://reviews.apache.org/r/42476/diff/3/?file=1201684#file1201684line327>
> >
> >     Why not use protoRequest here?

Good catch, thanks!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review115387
-----------------------------------------------------------


On Jan. 20, 2016, 9 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 9 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
>     https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota_handler.cpp f44736cd5849d4fb22a75c1238d433a1c0c9708d 
>   src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to