> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > <https://reviews.apache.org/r/42476/diff/2/?file=1200759#file1200759line56> > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is mostly used as the schema for the json > > request.
What are we optimizing here? Room for more fields? - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115127 ----------------------------------------------------------- On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42476/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 3:43 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris > Van Remoortere. > > > Bugs: MESOS-4410 > https://issues.apache.org/jira/browse/MESOS-4410 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d > include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 > src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 > src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 > src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 > > Diff: https://reviews.apache.org/r/42476/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
