----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ -----------------------------------------------------------
(Updated Jan. 29, 2016, 10:34 a.m.) Review request for mesos, Michael Park and Qian Zhang. Changes ------- Addressed Klaus' comment. Bugs: MESOS-4542 https://issues.apache.org/jira/browse/MESOS-4542 Repository: mesos Description ------- The `AvailableResourcesAfterRescinding` test became flaky after we stopped offering unreserved resources beyond quota in https://reviews.apache.org/r/42835. Hence the allocator offers rescinded resources to `framework1` if an allocation happens before the test finishes, which violates the expectation that `framework1` receives resources only once. Since we do not really care about allocations in this test but rather about rescinded resources, the fix is just to ignore subsequent offers to `framework1`. Diffs (updated) ----- src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 Diff: https://reviews.apache.org/r/42908/diff/ Testing ------- On Mac OS 10.10.4: `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure --gtest_repeat=5000` Thanks, Alexander Rukletsov