> On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 993-1000 > > <https://reviews.apache.org/r/42908/diff/2/?file=1225630#file1225630line993> > > > > Did we not need these before for some reason?
We did, it was a bug. I believe you mean we should then split the review in two: bugfix and logics update. > On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 990-991 > > <https://reviews.apache.org/r/42908/diff/2/?file=1225630#file1225630line990> > > > > Is this comment generally applied to the test? or is it related to the > > sequence of `stop` and `join` below? If it's the latter, could you explain > > how they're related? No, it's unrelated to the sequence of `stop` and `join`. I see it confuses the reader at this point, I'll move it higher above where we set expectations. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review118551 ----------------------------------------------------------- On Jan. 29, 2016, 10:34 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42908/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 10:34 a.m.) > > > Review request for mesos, Michael Park and Qian Zhang. > > > Bugs: MESOS-4542 > https://issues.apache.org/jira/browse/MESOS-4542 > > > Repository: mesos > > > Description > ------- > > The `AvailableResourcesAfterRescinding` test became flaky after we > stopped offering unreserved resources beyond quota in > https://reviews.apache.org/r/42835. Hence the allocator offers > rescinded resources to `framework1` if an allocation happens before > the test finishes, which violates the expectation that `framework1` > receives resources only once. Since we do not really care about > allocations in this test but rather about rescinded resources, the > fix is just to ignore subsequent offers to `framework1`. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 > > Diff: https://reviews.apache.org/r/42908/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" > ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure > --gtest_repeat=5000` > > > Thanks, > > Alexander Rukletsov > >