> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957> > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocator > > to do the `rescindOffer`? It makes sense to let allocator to descide how > > many resources/offer should be rescind. > > Alexander Rukletsov wrote: > If I understand you correctly, then it's because the allocator should > manage offers. Currently, the allocator allocates resources which are packed > into offers by the master. Moving this to allocator is quite a bit of > refactoring, agreed? Do you propose to do this refactoring as part of the > patch? I'm not sure how schould I "fix" the issue.
Yes, I agree it's quite a bit of refactoring; we definely not "fix" it in this path :). I thinke we can log a JIRA to discuss it: whether it worth to do; if worth, how. Is that OK? - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review116908 ----------------------------------------------------------- On Jan. 29, 2016, 6:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42908/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 6:34 p.m.) > > > Review request for mesos, Michael Park and Qian Zhang. > > > Bugs: MESOS-4542 > https://issues.apache.org/jira/browse/MESOS-4542 > > > Repository: mesos > > > Description > ------- > > The `AvailableResourcesAfterRescinding` test became flaky after we > stopped offering unreserved resources beyond quota in > https://reviews.apache.org/r/42835. Hence the allocator offers > rescinded resources to `framework1` if an allocation happens before > the test finishes, which violates the expectation that `framework1` > receives resources only once. Since we do not really care about > allocations in this test but rather about rescinded resources, the > fix is just to ignore subsequent offers to `framework1`. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 > > Diff: https://reviews.apache.org/r/42908/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" > ./bin/mesos-tests.sh --gtest_shuffle --gtest_break_on_failure > --gtest_repeat=5000` > > > Thanks, > > Alexander Rukletsov > >
