----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121840 -----------------------------------------------------------
src/Makefile.am (line 632) <https://reviews.apache.org/r/44260/#comment183684> Please update "src/CMakeLists.txt" as well, here and below. src/master/allocator/mesos/metrics.hpp (lines 28 - 30) <https://reviews.apache.org/r/44260/#comment183688> I actually don't think we should wright this obvious comment here, but maybe there are some historical reasons I'm not aware of. Please check it with your shepherd. Also, I think you can get rid of the blank line after the declaration. src/master/allocator/mesos/metrics.hpp (line 32) <https://reviews.apache.org/r/44260/#comment183686> Wrap `{` to the next line. src/master/allocator/mesos/metrics.cpp (line 22) <https://reviews.apache.org/r/44260/#comment183685> Kill one blank line - Alexander Rukletsov On March 3, 2016, 1:11 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44260/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 1:11 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44260/diff/ > > > Testing > ------- > > `make distcheck` on OS X. > > > Thanks, > > Benjamin Bannier > >
