> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, lines 28-30 > > <https://reviews.apache.org/r/44260/diff/3/?file=1279024#file1279024line28> > > > > I actually don't think we should wright this obvious comment here, but > > maybe there are some historical reasons I'm not aware of. Please check it > > with your shepherd. > > > > Also, I think you can get rid of the blank line after the declaration.
I use this since I saw it quite a lot elsewhere while I agree with you that it doesn't add much useful information. I removed the extra blank line though. > On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 32 > > <https://reviews.apache.org/r/44260/diff/3/?file=1279024#file1279024line32> > > > > Wrap `{` to the next line. Done. > On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.cpp, line 22 > > <https://reviews.apache.org/r/44260/diff/3/?file=1279025#file1279025line22> > > > > Kill one blank line Done. > On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/Makefile.am, line 632 > > <https://reviews.apache.org/r/44260/diff/3/?file=1279022#file1279022line632> > > > > Please update "src/CMakeLists.txt" as well, here and below. Good point I did not think about. I updated `src/CMakeLists.txt`, but am unsure what other files you have in mind. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121840 ----------------------------------------------------------- On March 3, 2016, 5:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44260/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 5:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Moved metrics of the hierarchical allocator to its own file. > > > Diffs > ----- > > src/CMakeLists.txt 0eabfad66f43adff12d08dbf34ca3db1b801c49e > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44260/diff/ > > > Testing > ------- > > `make distcheck` on OS X. > > > Thanks, > > Benjamin Bannier > >
