> On March 3, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 29 > > <https://reviews.apache.org/r/44260/diff/3/?file=1279024#file1279024line29> > > > > Maybe make it a struct? > > Benjamin Bannier wrote: > I am not sure why that would be useful; also, it is defined as a class.
I meant the `Metrics` class, sorry. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121861 ----------------------------------------------------------- On March 3, 2016, 4:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44260/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 4:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Moved metrics of the hierarchical allocator to its own file. > > > Diffs > ----- > > src/CMakeLists.txt 0eabfad66f43adff12d08dbf34ca3db1b801c49e > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44260/diff/ > > > Testing > ------- > > `make distcheck` on OS X. > > > Thanks, > > Benjamin Bannier > >
