----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121904 -----------------------------------------------------------
Ship it! src/master/allocator/mesos/metrics.hpp (line 26) <https://reviews.apache.org/r/44260/#comment183758> I'm not so sure about this `internal` namespace in an already `internal` namespace, still, apparently allocator likes to do so. - Alexander Rojas On March 3, 2016, 5:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44260/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 5:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Moved metrics of the hierarchical allocator to its own file. > > > Diffs > ----- > > src/CMakeLists.txt 0eabfad66f43adff12d08dbf34ca3db1b801c49e > src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44260/diff/ > > > Testing > ------- > > `make distcheck` on OS X. > > > Thanks, > > Benjamin Bannier > >
