-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44669/#review123206
-----------------------------------------------------------




src/master/contenders/contender.cpp (line 100)
<https://reviews.apache.org/r/44669/#comment185424>

    This should look more like:
    ```
    if (type.isNone()) {
      // return Standalone.
    }
    
    // return Module.
    ```



src/master/detectors/detector.cpp (line 127)
<https://reviews.apache.org/r/44669/#comment185425>

    Ditto here.


- Joseph Wu


On March 10, 2016, 3:46 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44669/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The createFromModule will be used to create a MasterContender/Detector
> from a module (specified using the --modules flag on the command
> line).
> 
> 
> Diffs
> -----
> 
>   src/master/contenders/contender.cpp PRE-CREATION 
>   src/master/detectors/detector.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>

Reply via email to