-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/#review123300
-----------------------------------------------------------



Sorry for the misunderstanding. As far as (sandbox) access-control is 
concerned, we can only isolate containers from each other, so each container 
can only have a single owner. With the default executor, the TaskInfo is 1:1 
with the container. But with a custom executor, the ExecutorInfo is 1:1 with 
the container.


include/mesos/mesos.proto (lines 440 - 442)
<https://reviews.apache.org/r/44570/#comment185510>

    Owner of the executor...



src/tests/master_validation_tests.cpp (lines 1184 - 1185)
<https://reviews.apache.org/r/44570/#comment185511>

    Not true. If an executorInfo is specified, then TaskInfo.owner is 
irrelevant, since the executor is the unit of containerization, ownership, and 
access control.
    The only reason we need a TaskInfo.owner is because there is no 
ExecutorInfo for the default command executor. Same holds true for CommandInfo.


- Adam B


On March 10, 2016, 4:49 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44570/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 4:49 a.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4772
>     https://issues.apache.org/jira/browse/MESOS-4772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To be able to authenticate HTTP requests for tasks, the authorizer has to
> determine who owns the tasks. This is achieved by adding an owner field to
> TaskInfo and ExecutorInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7 
>   include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c 
>   src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/tests/master_validation_tests.cpp 
> c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
> 
> Diff: https://reviews.apache.org/r/44570/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to