----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123401 -----------------------------------------------------------
Fix it, then Ship it! Just fix the v1 comments, and then I think we're good to go. Anybody else want to take a look before I commit? include/mesos/v1/mesos.proto (lines 440 - 442) <https://reviews.apache.org/r/44570/#comment185658> Update these comments to match the others. - Adam B On March 14, 2016, 3:46 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44570/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 3:46 a.m.) > > > Review request for mesos, Adam B and Joerg Schad. > > > Bugs: MESOS-4772 > https://issues.apache.org/jira/browse/MESOS-4772 > > > Repository: mesos > > > Description > ------- > > To be able to authenticate HTTP requests for tasks, the authorizer has to > determine who owns the tasks. This is achieved by adding an owner field to > TaskInfo and ExecutorInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a > include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/tests/master_validation_tests.cpp > c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 > > Diff: https://reviews.apache.org/r/44570/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
