----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44570/#review123399 -----------------------------------------------------------
Looks good. Just update the comments and error string. src/master/validation.cpp (line 382) <https://reviews.apache.org/r/44570/#comment185652> Update the error string. Perhaps "TaskInfo cannot have an Owner if ExecutorInfo is set" include/mesos/mesos.proto (lines 440 - 441) <https://reviews.apache.org/r/44570/#comment185653> "Owner of the executor. This field may be used by authorizers to determine access to executor-related information and actions." include/mesos/mesos.proto (lines 1222 - 1224) <https://reviews.apache.org/r/44570/#comment185654> "Owner of the task. This field may be used by authorizers to determine access to task/executor-related information and actions. If ExecutorInfo is present, use the owner field there instead." src/master/validation.cpp (lines 377 - 378) <https://reviews.apache.org/r/44570/#comment185655> Update the comment: "Validates that ownership is not set on TaskInfo if ExecutorInfo is present." src/tests/master_validation_tests.cpp (lines 1166 - 1167) <https://reviews.apache.org/r/44570/#comment185656> Update comment please. "This test verifies that owner can only be set in TaskInfo if ExecutorInfo is not present." - Adam B On March 14, 2016, 2:37 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44570/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 2:37 a.m.) > > > Review request for mesos, Adam B and Joerg Schad. > > > Bugs: MESOS-4772 > https://issues.apache.org/jira/browse/MESOS-4772 > > > Repository: mesos > > > Description > ------- > > To be able to authenticate HTTP requests for tasks, the authorizer has to > determine who owns the tasks. This is achieved by adding an owner field to > TaskInfo and ExecutorInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a > include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > src/tests/master_validation_tests.cpp > c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 > > Diff: https://reviews.apache.org/r/44570/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
