-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44570/#review123404
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto (line 440)
<https://reviews.apache.org/r/44570/#comment185659>

    Maybe we could add some more information about the potential values could 
be set for the owner field here (and below).
    I just imagine myself as a framework writer seeing this field...



include/mesos/mesos.proto (line 441)
<https://reviews.apache.org/r/44570/#comment185665>

    task/executor related information?



include/mesos/mesos.proto (line 1221)
<https://reviews.apache.org/r/44570/#comment185660>

    see comment above.



include/mesos/v1/mesos.proto (line 440)
<https://reviews.apache.org/r/44570/#comment185661>

    dito.



include/mesos/v1/mesos.proto (line 441)
<https://reviews.apache.org/r/44570/#comment185666>

    dito.



include/mesos/v1/mesos.proto (line 1218)
<https://reviews.apache.org/r/44570/#comment185662>

    dito.



src/master/validation.cpp (line 381)
<https://reviews.apache.org/r/44570/#comment185663>

    s/Owner/owner
    
    I addition I personally would prefer a more descriptive Error message 
(something like 'as the owner will be inherited from the executor'), but this 
is ok for me right now.



src/tests/master_validation_tests.cpp (line 1166)
<https://reviews.apache.org/r/44570/#comment185667>

    This test verifies legal combination of set owner field for tasks and 
executors.



src/tests/master_validation_tests.cpp (line 1196)
<https://reviews.apache.org/r/44570/#comment185664>

    A task without owner and an executor....


- Joerg Schad


On March 14, 2016, 11:06 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44570/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 11:06 a.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4772
>     https://issues.apache.org/jira/browse/MESOS-4772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To be able to authenticate HTTP requests for tasks, the authorizer has to
> determine who owns the tasks. This is achieved by adding an owner field to
> TaskInfo and ExecutorInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a 
>   include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144 
>   src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/tests/master_validation_tests.cpp 
> c9bc38ce604d2d44d6e6b1286507d1c45e5e9e25 
> 
> Diff: https://reviews.apache.org/r/44570/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to