----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review123381 -----------------------------------------------------------
I like the test you have here as a higher-level integration test. Could you also add lower-level unit tests for the UpdateWeights Operation, similar to the RegistrarTest.UpdateQuota test in `registrar_tests.cpp`? src/tests/dynamic_weights_tests.cpp (line 207) <https://reviews.apache.org/r/44511/#comment185632> Fix indent src/tests/dynamic_weights_tests.cpp (line 217) <https://reviews.apache.org/r/44511/#comment185633> Fix indent - Adam B On March 9, 2016, 2:03 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44511/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 2:03 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4797 > https://issues.apache.org/jira/browse/MESOS-4797 > > > Repository: mesos > > > Description > ------- > > Add registry tests for /weights endpoint. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44511/diff/ > > > Testing > ------- > > Add three sub tests for /weights endpoint registry in this patch: > > 1. Tests whether the weights replicated log is initialized with the > `--weights` flag when bootstrapping the cluster. > 2. Tests whether the weights replicated log can be updated with `/weights` > endpoint. > 3. Tests whether the `--weights` flag is ignored and use the registry value > instead when Mesos master subsequently starts with `--weights` flag still > specified. > > > make && make check. > > > Thanks, > > Yongqiao Wang > >
