----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review123608 -----------------------------------------------------------
src/examples/long_lived_framework.cpp (line 98) <https://reviews.apache.org/r/44836/#comment185844> Need remove cast if we change taskId to string. src/examples/long_lived_framework.cpp (line 99) <https://reviews.apache.org/r/44836/#comment185846> Ditto src/examples/long_lived_framework.cpp (line 130) <https://reviews.apache.org/r/44836/#comment185845> Also need update here if the type of taskId is string. - haosdent huang On March 15, 2016, 6:54 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44836/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 6:54 a.m.) > > > Review request for mesos and haosdent huang. > > > Repository: mesos > > > Description > ------- > > Current WebUI sorts taskId lexically, which results in non-intuitive ordering. > This patch updates long_lived_framework to use `000001`, `000002` instead. > > Signed-off-by: Zhou Xing <[email protected]> > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > 0000289a0b9dd3d1ce30f20dd9bb381126bff30c > > Diff: https://reviews.apache.org/r/44836/diff/ > > > Testing > ------- > > make check > > In addition, `long_lived_framework` is ran and we confirm correct sorting of > `TaskID` in WebUI > > > Thanks, > > Jay Guo > >
