> On March 15, 2016, 7:04 a.m., haosdent huang wrote: > > > > haosdent huang wrote: > I also notice the submitter `[email protected]` is different with > signer `Zhou Xing <[email protected]>`. I suggest don't do it like this. > > Jay Guo wrote: > We are following pair programming pattern and use git-duet. Will do clean > commit in the future. Also, IMHO, sorting task ID in WebUI by detecting > string type would be a more appropriate solution, instead of forcing > framework to use string IDs. Maybe we could bring this up at a later point.
Agree with you. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review123608 ----------------------------------------------------------- On March 15, 2016, 7:49 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44836/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 7:49 a.m.) > > > Review request for mesos and haosdent huang. > > > Repository: mesos > > > Description > ------- > > Current WebUI sorts taskId lexically, which results in non-intuitive ordering. > This patch updates long_lived_framework to use `000001`, `000002` instead. > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > 0000289a0b9dd3d1ce30f20dd9bb381126bff30c > > Diff: https://reviews.apache.org/r/44836/diff/ > > > Testing > ------- > > make check > > In addition, `long_lived_framework` is ran and we confirm correct sorting of > `TaskID` in WebUI > > > Thanks, > > Jay Guo > >
