----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review124364 -----------------------------------------------------------
src/examples/long_lived_framework.cpp (line 88) <https://reviews.apache.org/r/44836/#comment186878> I think we need check `format()`'s result; if `tasksLaunched` is bigger than `999999`, what's the behaviour? - Klaus Ma On March 16, 2016, 10:27 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44836/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 10:27 a.m.) > > > Review request for mesos and haosdent huang. > > > Repository: mesos > > > Description > ------- > > Current WebUI sorts taskId lexically, which results in non-intuitive ordering. > This patch updates long_lived_framework to use `000001`, `000002` instead. > > > Diffs > ----- > > src/examples/long_lived_framework.cpp > 0000289a0b9dd3d1ce30f20dd9bb381126bff30c > > Diff: https://reviews.apache.org/r/44836/diff/ > > > Testing > ------- > > make check > > In addition, `long_lived_framework` is ran and we confirm correct sorting of > `TaskID` in WebUI > > > Thanks, > > Jay Guo > >
