----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123984 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 84) <https://reviews.apache.org/r/44514/#comment186336> Define a constructor NetworkResultInfo(_name, _result): name(_name), result(_result) Will be useful while initializing objects. src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 88) <https://reviews.apache.org/r/44514/#comment186333> Should this be a `Result` instead of an `Option` ? Since either the container was able to join the network or wasn't due to an error. I am thinking about a case where a container wants to join multiple networks, it is successful in joining a few but fails due to misconfig or unavailable IP addresses. In this case should we store an Error? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 238) <https://reviews.apache.org/r/44514/#comment186337> If you have the constructor you can do NetworkResultInfo(name) src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 240 - 244) <https://reviews.apache.org/r/44514/#comment186338> I think this comment is for static IP addresses. You should be prepoulating the NetworkResultInfo with the IP Address and use it when calling the plugin. `host-local` is something different right? It just uses a local IPAM to allocated addresses. - Avinash sridharan On March 16, 2016, 12:57 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 12:57 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
