----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124881 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 117) <https://reviews.apache.org/r/44514/#comment187574> Can you use 'Owned<Info>' here? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 228) <https://reviews.apache.org/r/44514/#comment187576> s/i/ifIndex/ src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 229) <https://reviews.apache.org/r/44514/#comment187577> s/names/networkNames/ src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 249 - 250) <https://reviews.apache.org/r/44514/#comment187579> I would make it more explicit here: ``` NetworkInfo networkInfo; networkInfo.networkName = networkName; networkInfo.ifName = "eth" + stringify(ifIndex); networkInfos.put(name, networkInfo); ``` - Jie Yu On March 22, 2016, 9:50 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:50 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
