> On March 24, 2016, 5:04 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 228 > > <https://reviews.apache.org/r/44514/diff/9/?file=1311483#file1311483line228> > > > > You always have ifIndex==0 here, it is never changed. So either you > > miss some code or it is not needed at all.
Thanks for catching this! Will fix it soon. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125131 ----------------------------------------------------------- On March 23, 2016, 1:10 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 1:10 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 3878a7e85fe24175b3bd5e3a6268cf32a07f2d8b > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9552312f9ba1e4df6564cfb737cc41e041cf4407 > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
