> On March 19, 2016, 9:16 a.m., Adam B wrote:
> > src/tests/mesos.cpp, line 177
> > <https://reviews.apache.org/r/44515/diff/11/?file=1306307#file1306307line177>
> >
> >     Why use `os::getcwd()` instead of `directory.get()` like "credential" 
> > and "fetch" above? Seems like `CreateSlaveFlags` wanted to use a temporary 
> > directory removed later.
> >     I'm not convinced these two are equivalent.

Whoops - thanks for catching this Adam!!! You are correct, these aren't 
equivalent and this was in fact causing the race that I had to patch up :-) 
Using `directory.get()` gives us a different temporary directory for each of 
the agents created in `ResourceOffersTest.ResourceOfferWithMultipleSlaves`, 
while using `os::getcwd()` uses a common directory for all of them, which 
allows them to step on each others' toes when they're being spun up.

Changing this to `directory.get()` solves the problem, and is clearly what I 
should be doing here. Patch has been updated.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review124387
-----------------------------------------------------------


On March 20, 2016, 5:27 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 5:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flags for HTTP authentication.
> 
> Three command-line flags have been added to the agent to enable HTTP 
> authentication: `--authenticate_http`, `--http_credentials`, and 
> `--http_authenticators`.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 4189c07dbad754e51f1a067ecbb4c99ae42a386f 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
> 
> Diff: https://reviews.apache.org/r/44515/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` was used to test on both OSX and Ubuntu 14.04.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to