----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124122 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (lines 21 - 23) <https://reviews.apache.org/r/44138/#comment187105> where are these used? 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (line 26) <https://reviews.apache.org/r/44138/#comment187113> why are these in `internal`? 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (lines 28 - 36) <https://reviews.apache.org/r/44138/#comment187104> Let's namespace these with `socket` since both functions currently start with `socket`. How about `is_restartable_error(int error)` and `is_retryable_error`? 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (line 43) <https://reviews.apache.org/r/44138/#comment187102> missing whitespace between `<0` 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (line 46) <https://reviews.apache.org/r/44138/#comment187103> new line after closing brace of `if` 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (lines 47 - 48) <https://reviews.apache.org/r/44138/#comment187101> missing new line 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp (line 29) <https://reviews.apache.org/r/44138/#comment187100> Missing `:` after `TODO(dparavat)` 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp (line 30) <https://reviews.apache.org/r/44138/#comment186505> typo. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (lines 16 - 17) <https://reviews.apache.org/r/44138/#comment187106> Where are these used? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (line 19) <https://reviews.apache.org/r/44138/#comment187109> I think we can put the system include above our includes. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (lines 24 - 32) <https://reviews.apache.org/r/44138/#comment187110> same comments as above. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (line 51) <https://reviews.apache.org/r/44138/#comment187108> comments end with a `.` 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp (line 52) <https://reviews.apache.org/r/44138/#comment187107> Missing the `stout/abort.hpp` include? - Joris Van Remoortere On March 17, 2016, 6:48 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 6:48 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
