----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (lines 23 - 28) <https://reviews.apache.org/r/44138/#comment187759> Can you add comments for each of these explaining the intended usage? I don't think it's clear to the average user what the difference is between `restartable` and `retryable` 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp (line 30) <https://reviews.apache.org/r/44138/#comment187760> Should `EINPROGRESS` be in here? would a retry not cause an `EALREADY`? 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp (line 17) <https://reviews.apache.org/r/44138/#comment187441> where is this used? 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp (line 33) <https://reviews.apache.org/r/44138/#comment187440> typo - Joris Van Remoortere On March 21, 2016, 10:53 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 10:53 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
