----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124964 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 204 - 205) <https://reviews.apache.org/r/45186/#comment187686> what about: foreach ( const string& file, strings::split(flags.system_config_files.get(), ",")) { src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 221) <https://reviews.apache.org/r/45186/#comment187702> I thihk that we also need to make sure the file exist before put it to systemConfig, otherwise, the bind mount will be failed. - Guangya Liu On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45186/ > ----------------------------------------------------------- > > (Updated 三月 23, 2016, 12:20 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-3003 > https://issues.apache.org/jira/browse/MESOS-3003 > > > Repository: mesos > > > Description > ------- > > Implemented user specified system config files support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > f97a9a92895387a9d504810a2ae971cfb5d3dbb4 > > Diff: https://reviews.apache.org/r/45186/diff/ > > > Testing > ------- > > make check > > tested manually with mesos-execute to cat /etc/resolv.conf from an alpine > image. > > > Thanks, > > Gilbert Song > >
