> On 三月 23, 2016, 6:46 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > <https://reviews.apache.org/r/45186/diff/1/?file=1311199#file1311199line204> > > > > what about: > > > > foreach ( > > const string& file, > > strings::split(flags.system_config_files.get(), ",")) { > > Gilbert Song wrote: > Thanks for mentioning this. We are currently supporting both formats. We > may prefer the original one here since that format is used around this part > of codes.
Yes, but we did have patches https://reviews.apache.org/r/44653/diff/5#index_header to address such issue, so it would be great if we can follow this format ;-) - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124964 ----------------------------------------------------------- On 三月 23, 2016, 12:20 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45186/ > ----------------------------------------------------------- > > (Updated 三月 23, 2016, 12:20 a.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-3003 > https://issues.apache.org/jira/browse/MESOS-3003 > > > Repository: mesos > > > Description > ------- > > Implemented user specified system config files support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > f97a9a92895387a9d504810a2ae971cfb5d3dbb4 > > Diff: https://reviews.apache.org/r/45186/diff/ > > > Testing > ------- > > make check > > tested manually with mesos-execute to cat /etc/resolv.conf from an alpine > image. > > > Thanks, > > Gilbert Song > >
