> On March 22, 2016, 11:51 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > <https://reviews.apache.org/r/45186/diff/1/?file=1311199#file1311199line231> > > > > Put this check to the block of > > if (flags.system_config_files.isSome()) { > > } ?
It can be a case that any of the four default sys config files missing on the host for some os env, so we check all files which will be bind mounted here. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124976 ----------------------------------------------------------- On March 22, 2016, 5:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45186/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 5:20 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-3003 > https://issues.apache.org/jira/browse/MESOS-3003 > > > Repository: mesos > > > Description > ------- > > Implemented user specified system config files support. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > f97a9a92895387a9d504810a2ae971cfb5d3dbb4 > > Diff: https://reviews.apache.org/r/45186/diff/ > > > Testing > ------- > > make check > > tested manually with mesos-execute to cat /etc/resolv.conf from an alpine > image. > > > Thanks, > > Gilbert Song > >
