> On March 22, 2016, 11:46 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205
> > <https://reviews.apache.org/r/45186/diff/1/?file=1311199#file1311199line204>
> >
> >     what about:
> >     
> >     foreach (
> >         const string& file,
> >         strings::split(flags.system_config_files.get(), ",")) {

Thanks for mentioning this. We are currently supporting both formats. We may 
prefer the original one here since that format is used around this part of 
codes.


> On March 22, 2016, 11:46 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 221
> > <https://reviews.apache.org/r/45186/diff/1/?file=1311199#file1311199line221>
> >
> >     I thihk that we also need to make sure the file exist before put it to 
> > systemConfig, otherwise, the bind mount will be failed.

They are checked together in the loop below. Yes, we should be careful about 
this.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45186/#review124964
-----------------------------------------------------------


On March 22, 2016, 5:20 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45186/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-3003
>     https://issues.apache.org/jira/browse/MESOS-3003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented user specified system config files support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
> f97a9a92895387a9d504810a2ae971cfb5d3dbb4 
> 
> Diff: https://reviews.apache.org/r/45186/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> tested manually with mesos-execute to cat /etc/resolv.conf from an alpine 
> image.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to