----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125465 -----------------------------------------------------------
LGTM modulo Anand's comments. Please also update the CHANGELOG. - Vinod Kone On March 25, 2016, 6:58 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 6:58 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > ------- > > This fix changes Call and Event Type enums in executor.proto > optional for the purpose of backwards compatibility. (MESOS-5015) > > > Diffs > ----- > > include/mesos/executor/executor.proto > 6b4141f0aac27be5a4998f16e986fa87a7047834 > include/mesos/v1/executor/executor.proto > d7b1dd5eec9bcd424c7859d89471148bce8fe16e > src/examples/test_http_executor.cpp > 562b0acfd8555b9b773175f53defe0e7e2744641 > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > > Diff: https://reviews.apache.org/r/45304/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
